Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker CPU shares gauge #1597

Merged
merged 3 commits into from Apr 23, 2018
Merged

Add docker CPU shares gauge #1597

merged 3 commits into from Apr 23, 2018

Conversation

hkaj
Copy link
Member

@hkaj hkaj commented Apr 16, 2018

What does this PR do?

Add docker CPU shares gauge

Motivation

Additional Notes

Anything else we should know when reviewing?

if err == nil {
ret.Shares = shares
} else {
log.Debugf("missing cpu shares stat for %s: %s", c.ContainerID, err.Error())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/missing/Missing

mfpierre
mfpierre previously approved these changes Apr 16, 2018
Copy link
Contributor

@xvello xvello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkaj hkaj merged commit 8607baa into master Apr 23, 2018
@hkaj hkaj deleted the haissam/docker-cpu-shares branch April 23, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants